tree 97d89e81e8d91779bf58480c9f2f5f3ba2797c1b
parent 814e0d74b53fe2868d6050d4fc1262e02a4aba8e
author Robert Findley <rfindley@google.com> 1652289782 -0400
committer Robert Findley <rfindley@google.com> 1652803692 +0000

internal/span: eliminate Converter and FileConverter

The only real implementation of position conversion was via a
*token.File, so refactor the converter logic to eliminate the Converter
interface, and just use a single converter implementation that uses a
*token.File to convert between offsets and positions.

This change is meant to be a zero-impact refactoring for non-test code.
As such, I abstained from panicking in several places where it would
make sense. In later CLs, once the bug reporting API lands, we can
insert bug reports in these places.

Change-Id: Id2e503acd80d089bc5d73e983215784015471f04
Reviewed-on: https://go-review.googlesource.com/c/tools/+/405546
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>