|author||Rob Findley <firstname.lastname@example.org>||Tue Jan 12 23:02:22 2021 -0500|
|committer||Robert Findley <email@example.com>||Wed Jan 13 18:03:00 2021 +0000|
gopls/internal/regtest: fix synchronization for TestUseGoplsMod Jumping to definition in a regtest can indirectly lead to a didOpen call, so the awaits added to TestUseGoplsMod to synchronize metadata were ineffectual. On Android, this can lead to the race described in golang/go#43652. But in any case, all this bookkeeping of notifications is fragile. Avoid it entirely by having the fake editor keep track of notification statistics. In the future, we should use this to clean up many existing regtests. For golang/go#43554 For golang/go#39384 Change-Id: Icd1619bd5cdd2f646d1a0050f5beaf2ab1c27f37 Reviewed-on: https://go-review.googlesource.com/c/tools/+/283512 Run-TryBot: Robert Findley <firstname.lastname@example.org> gopls-CI: kokoro <email@example.com> Trust: Robert Findley <firstname.lastname@example.org> TryBot-Result: Go Bot <email@example.com> Reviewed-by: Rebecca Stambler <firstname.lastname@example.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools,
vet for example, are included in binary Go distributions.
Others, including the Go
guru and the test coverage tool, can be fetched with
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run
go get -u golang.org/x/tools/.... You can also manually git clone the repository to
This repository uses prettier to format JS and CSS files.
The version of
prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.