gopls/internal/regtest: fix synchronization for TestUseGoplsMod

Jumping to definition in a regtest can indirectly lead to a didOpen
call, so the awaits added to TestUseGoplsMod to synchronize metadata
were ineffectual. On Android, this can lead to the race described in

But in any case, all this bookkeeping of notifications is fragile. Avoid
it entirely by having the fake editor keep track of notification
statistics. In the future, we should use this to clean up many existing

For golang/go#43554
For golang/go#39384

Change-Id: Icd1619bd5cdd2f646d1a0050f5beaf2ab1c27f37
Run-TryBot: Robert Findley <>
gopls-CI: kokoro <>
Trust: Robert Findley <>
TryBot-Result: Go Bot <>
Reviewed-by: Rebecca Stambler <>
4 files changed
tree: 64d946f2de81446bacb0059f5038d01b1186fc57
  1. .gitattributes
  2. .gitignore
  3. .prettierrc
  10. benchmark/
  11. blog/
  12. cmd/
  13. codereview.cfg
  14. container/
  15. copyright/
  16. cover/
  17. go.mod
  18. go.sum
  19. go/
  20. godoc/
  21. gopls/
  22. imports/
  23. internal/
  24. playground/
  25. present/
  26. refactor/
  27. txtar/

Go Tools


This subrepository holds the source for various packages and tools that support the Go programming language.

Some of the tools, godoc and vet for example, are included in binary Go distributions.

Others, including the Go guru and the test coverage tool, can be fetched with go get.

Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.


The easiest way to install is to run go get -u You can also manually git clone the repository to $GOPATH/src/

JS/CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.

Report Issues / Send Patches

This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see

The main issue tracker for the tools repository is located at Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.