commit | f6a1a6ff8e04e3068b8a3cf01747c06092ffd1d0 | [log] [tgz] |
---|---|---|
author | Rebecca Stambler <rstambler@golang.org> | Wed Oct 16 16:31:27 2019 -0400 |
committer | Rebecca Stambler <rstambler@golang.org> | Wed Oct 16 22:21:47 2019 +0000 |
tree | 1e6cee8a6a09a052952e0fc4ca4f74a958392e8b | |
parent | eec4c98bf5a6a9765c9de84cf61e447130fe8e54 [diff] |
internal/lsp: check if the go/packages context has been canceled Recently been noticing errors where we don't have full metadata for a given package. It seems to me that, since we added the context to the packages.Config, there have been cases where the context is canceled on the first load, and then we type-check with incomplete data. I'm still not sure if allowing go/packages to be canceled is the correct approach. Change-Id: I6767ce763538bd579458c8f8db07f15c9eec7b4a Reviewed-on: https://go-review.googlesource.com/c/tools/+/201518 Run-TryBot: Rebecca Stambler <rstambler@golang.org> Reviewed-by: Muir Manders <muir@mnd.rs> Reviewed-by: Michael Matloob <matloob@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.