tree a55551acf054e94404d10337f6b3d4e5593ed62e
parent 6290d8a967be4ebd02218f5c53858de30b9107f3
author Robert Findley <rfindley@google.com> 1691799067 -0400
committer Robert Findley <rfindley@google.com> 1692022366 +0000

gopls: fix raciness related to TestOrphanedFiles

While investigating the high rate of flakiness in TestOrphanedFiles, I
found two problems:

- The change to use Await(...) rather than AfterChange(..), which was
  intended to *avoid* flakes due to asynchronous log messages, actually
  increased flakiness. After that change, the test can sometimes proceed
  to make additional edits before change processing completes, so that
  the load succeeds but the snapshot is cloned before the resulting
  state can be written (sigh...).
- If the load succeeds, we should proceed to update state even if the
  context is cancelled. Writing the state is not expensive.

Fixes golang/go#61521

Change-Id: I4e70526a0108013c66d378da966289a7c2f5dbe2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/518975
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>