tree a8795de975ac0ab5233be8dd16b667a482829754
parent 7b04e8b59ec2e614a9a351d6da0ae4ae69f4ca12
author Alan Donovan <adonovan@google.com> 1656690754 -0400
committer Alan Donovan <adonovan@google.com> 1656692520 +0000

internal/lsp/source: reduce allocation in workspace-symbols

dynamicSymbolMatch is an allocation hotspot (9% of all bytes),
because it allocates a 3-element []string that quickly becomes
garbage. This change passes in an empty slice with spare capacity
allowing the same array to be reused throughout the matchFile loop.

BenchmarkSymbols on k8s shows -72% bytes, -88% allocs, -9% wall time.

Change-Id: Id20c7cd649874a212e4d4c5f1aa095277b044a5b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/415500
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>