tree a2602d47ec523272cce1dac634054c124715cc1e
parent f3e53e5cc3bae1d9d27cec1ce5cc983fef5a6061
author Alan Donovan <adonovan@google.com> 1673999602 -0500
committer Alan Donovan <adonovan@google.com> 1674004565 +0000

gopls/internal/lsp/source: include ITVs in global references

The global search for references should include intermediate
test variants (ITVs), because the rdeps of every variant are disjoint.
The existing comment was mistaken.

The local search does not need them for the valid reason given in
the existing comment.

The previous call to RemoveIntermediateTestVariants had not
quite the intended effect because we forgot to use its result. (D'oh.)
The effect of the change in the test was to expose the bug
by creating an ordinary test variant.

Updates golang/go#57795

Change-Id: I1852aebf81ae0d169191834eb9a880d0ba90bc6e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/462497
Reviewed-by: Robert Findley <rfindley@google.com>
Run-TryBot: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>