tree 42a5b13e74aac4d517e9ae2fe3fc7d299ea6df7d
parent c224aaef06a9db6cd0c48edec48303984f8c9750
author Alan Donovan <adonovan@google.com> 1674683017 -0500
committer Alan Donovan <adonovan@google.com> 1674689645 +0000

gopls/internal/lsp/cmd/test: delete marker-based tests of gopls cmd

These tests were an implementation of the tests.Test marker-test
machinery, based on invoking the logic of the gopls command,
within the same process. The marker tests exercise server
logic, which is best done by making LSP requests, as the lsp_test
does.

Client logic in the gopls command and its subcommands is
best exercised by fork+execing the command, and exercising
features on the client, such as flags, argument parsing, and
output printing. That's what the new integration_test does.

With this change we are down to one implementation of tests.Tests,
which means we can start to change it to make it usable from
regtests too.

Updates golang/go#54845

Change-Id: Ia00897f0268ed4c293e716e1d34d9c84cfdf3109
Reviewed-on: https://go-review.googlesource.com/c/tools/+/463555
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>