Google Git
Sign in
go / tools / f3c36a20991b11a5f6b0dd2049e40bcd21bc3530
commitf3c36a20991b11a5f6b0dd2049e40bcd21bc3530[log] [tgz]
authorAlan Donovan <adonovan@google.com>Wed Jan 25 16:43:37 2023 -0500
committerAlan Donovan <adonovan@google.com>Wed Jan 25 23:34:05 2023 +0000
tree42a5b13e74aac4d517e9ae2fe3fc7d299ea6df7d
parentc224aaef06a9db6cd0c48edec48303984f8c9750 [diff]
gopls/internal/lsp/cmd/test: delete marker-based tests of gopls cmd

These tests were an implementation of the tests.Test marker-test
machinery, based on invoking the logic of the gopls command,
within the same process. The marker tests exercise server
logic, which is best done by making LSP requests, as the lsp_test
does.

Client logic in the gopls command and its subcommands is
best exercised by fork+execing the command, and exercising
features on the client, such as flags, argument parsing, and
output printing. That's what the new integration_test does.

With this change we are down to one implementation of tests.Tests,
which means we can start to change it to make it usable from
regtests too.

Updates golang/go#54845

Change-Id: Ia00897f0268ed4c293e716e1d34d9c84cfdf3109
Reviewed-on: https://go-review.googlesource.com/c/tools/+/463555
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
22 files changed
tree: 42a5b13e74aac4d517e9ae2fe3fc7d299ea6df7d
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. godoc/
  9. gopls/
  10. imports/
  11. internal/
  12. playground/
  13. present/
  14. refactor/
  15. txtar/
  16. .gitattributes
  17. .gitignore
  18. .prettierrc
  19. codereview.cfg
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.

The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.