commit | 7424a4db47b8e19a8d1c162aced1b0c5d421dd3a | [log] [tgz] |
---|---|---|
author | Robert Findley <rfindley@google.com> | Thu Jan 13 15:38:31 2022 -0500 |
committer | Robert Findley <rfindley@google.com> | Fri Jan 14 17:01:02 2022 +0000 |
tree | 53166f005b0f9ee372b15acd12d90dbe7687562d | |
parent | 4e31bdea7810f35a2654fd9a81602f35d437d00f [diff] |
internal/lsp/cache: fix check for excluded paths in locateTemplateFiles The pathExcludedByFilter helper function expects path to be relative to the workspace folder. This is a confusing API, and led to us passing absolute paths when checking for excluded template files. Fix it, add a regtest, and add a TODO to clean up the API. Fixes golang/go#50431 Change-Id: Iedcf0dd9710e541c9fb8c296d9856a13ef3fbcb6 Reviewed-on: https://go-review.googlesource.com/c/tools/+/378398 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> Reviewed-by: Ian Cottrell <iancottrell@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go install
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go install golang.org/x/tools/...@latest
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.