| commit | 72e4d1bb8d47cc5e6d8187a5b4137a8f38cc270e | [log] [tgz] |
|---|---|---|
| author | Matthew Dempsky <mdempsky@google.com> | Mon Jun 28 09:58:31 2021 -0700 |
| committer | Matthew Dempsky <mdempsky@google.com> | Tue Jun 29 19:12:30 2021 +0000 |
| tree | 6bfc2c3dbd75ca748e9be45945bb5865ecb6ca3a | |
| parent | 100b2292617116fbd4767024dfe29e2da1ee98b8 [diff] |
go/internal/cgo: handle symlinks with $PWD, not -srcdir In CL 293250, I changed x/tools/go/loader to invoke cgo using the -srcdir option, rather than chdir'ing into the source directory. But evidently cgo's -srcdir option does not affect #include processing of relative file paths, so this ended up breaking packages that relied on the latter. This CL reverts back to chdir'ing into the source directory, but also sets the PWD environment variable. This appears to be how cmd/go invokes tools and handles symlinks. Fixes golang/go#46877. Change-Id: Ia538c5d8722b151a4547f73188f6537e0551136f Reviewed-on: https://go-review.googlesource.com/c/tools/+/331409 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.