Google Git
Sign in
go / tools / efaab950fc6e6c5639279a3e222a50bf113a67f0
commitefaab950fc6e6c5639279a3e222a50bf113a67f0[log] [tgz]
authorAlan Donovan <adonovan@google.com>Mon Sep 11 08:29:54 2023 -0400
committerGopher Robot <gobot@golang.org>Wed Sep 13 21:01:52 2023 +0000
treefb5baf90344b2a7db898cc2a299362d2df461ffd
parentd98bc1a0158f15696e2533b6a19613ddc86a2a56 [diff]
internal/refactor/inline: simplify f(slice...) calls

This change causes f(slice...) calls to be reduced
to f(slice), and the corresponding parameter
func(...T) to be replaced by func([]T), enabling
parameter elimination and reduction.

This is one of several baby steps towards handling
the richness of variadic and spread calls.

Also:
- split the arrays of params and results in
  AnalyzeCallee; no need for Kind field.
- gather parameters (incl. receiver) in the
  same manner as we gather arguments,
  and set them to nil (just like arguments)
  when we eliminate them.
- Enable inliner logging in gopls.
  Curious users can read the log to find out
  why the inliner chose a given strategy.

Also, tests.

Change-Id: I2ba7dbf284c1de8c4fb0c16ef77b8df7f33398da
Reviewed-on: https://go-review.googlesource.com/c/tools/+/527676
Reviewed-by: Robert Findley <rfindley@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
4 files changed
tree: fb5baf90344b2a7db898cc2a299362d2df461ffd
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. godoc/
  9. gopls/
  10. imports/
  11. internal/
  12. playground/
  13. present/
  14. refactor/
  15. txtar/
  16. .gitattributes
  17. .gitignore
  18. .prettierrc
  19. codereview.cfg
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.

The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.