commit | ef80cdb6ec6d94b8e8d05f986b368bf925fa330e | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Wed Feb 03 13:24:46 2021 -0800 |
committer | Rebecca Stambler <rstambler@golang.org> | Fri Feb 05 20:20:24 2021 +0000 |
tree | 2f13038193258debb6d5be67b636dda32754934a | |
parent | b30482dd32ce7e0e7445a4c97e488d84f7cbdb31 [diff] |
internal/lsp/completion: fix untyped int type inference For index expressions, optional "make" args, and composite literal slice/array keys, we were inferring an expected type of int instead of untyped int. This caused candidate rankings to not be quite right in general, and in particular, after support for automatic type conversions was added, the issue manifested as: var foo []int var bar int32 foo[ba<>] // completed to "int(bar)" instead of "bar" Fixes golang/go#43375. Change-Id: I6daef7d23b767f296bdbbc8f47f5b2c972ad9b80 Reviewed-on: https://go-review.googlesource.com/c/tools/+/289272 Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.