tree af05d8c0d0c52302bace669e2f6f9858b2df8d11
parent ebc084af8ba794babff1d58912b41608629acd72
author Ruslan Nigmatullin <elessar@dropbox.com> 1655149965 +0000
committer Alan Donovan <adonovan@google.com> 1655220012 +0000

internal/lsp/cache: cache known subdirs pattern

Known subdirs change rarely and it's quite expensive to compute
a glob pattern derived from them, so cache computation result
and inherit it across generations.

Computation cost is divided ≈evenly between `sort.Sort` and
`span.URI.Filename` calls, and there is no trivial way to optimize
them away besides caching.

Benchmark (didChange in kubernetes): ~37ms->30ms

Change-Id: Idb1691c76b8ff163dc61f637f07229498888606c
GitHub-Last-Rev: cd99a9ce5c797afb5aaa9b478fcf433edd0dc03c
GitHub-Pull-Request: golang/tools#383
Reviewed-on: https://go-review.googlesource.com/c/tools/+/411636
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>