| commit | eaaaedc6afa77716257353d809d96dc66c41a3fb | [log] [tgz] |
|---|---|---|
| author | Rebecca Stambler <rstambler@golang.org> | Wed Jul 22 01:29:34 2020 -0400 |
| committer | Rebecca Stambler <rstambler@golang.org> | Mon Jul 27 15:46:26 2020 +0000 |
| tree | 365f4fba03dfa880688d81b28b4d5220d2d4eaf7 | |
| parent | 102e7d35703151d99b09a7158e6fc667492075b5 [diff] |
internal/lsp: fix hover link for embedded fields and methods Our logic to generate documentation links did not account for embedded fields and methods. The types.Info.ObjectOf an embedded field returns the *types.Var created for the field, not its types.TypeName, so we have to navigate back to the actual definition of the field. This requires traversing through all of the named types in the top-level type. Fixes golang/go#40294 Change-Id: Ia6573aebe66b7f60e2d6861a381cd7b07e7d7eaa Reviewed-on: https://go-review.googlesource.com/c/tools/+/244178 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.