commit 5adc67163c21f2743790e37e54c2b0eb629748ee
author Muir Manders <muir@mnd.rs> Tue Sep 17 15:52:19 2019 -0700
committer Rebecca Stambler <rstambler@golang.org> Wed Sep 25 22:58:16 2019 +0000
tree 8ff053aae6ffd0b28cbd9bbdeb308e5dcfe7a3ec
parent e4ea94538f5b7d27f3dc7eeac23448f6358998eb

internal/lsp: improve completions in *ast.FieldList

Now we always expect type names inside of *ast.FieldList. This expands
the previous func signature logic to also work for *ast.StructType
and *ast.InterfaceType. For example, we will now prefer type names in
cases like:

type myStruct struct { i i<> }

Also, fix a check for anonymous fields to make sure the field is
actually embedded. This fixes cases like this to properly have no
completions:

type myStruct struct { i<> i }

where this will still give type name completions:

type myStruct struct { i<> }

I introduced a new error type source.ErrIsDefinition so source_test.go
could avoid erroring out on tests that make sure definition
identifiers have no completions.

Fixes golang/go#34412.

Change-Id: Ib56cb52af639f2e2b132274d1f04f8074c0d9353
Reviewed-on: https://go-review.googlesource.com/c/tools/+/196560
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>