| commit | c229649527913a05dace78a8e1074260b2e785f4 | [log] [tgz] |
|---|---|---|
| author | Muir Manders <muir@mnd.rs> | Fri Feb 14 09:02:32 2020 -0800 |
| committer | Rebecca Stambler <rstambler@golang.org> | Fri Feb 14 17:25:38 2020 +0000 |
| tree | dd5fc46280c62969b335ccbd5828f876bd1b3745 | |
| parent | 88be01311a71af0cda63cfee99fafd9f44e84fe1 [diff] |
internal/lsp/cache: fix crash fixing curlies near EOF
We were crashing in cases like:
1: func foo() {
2: if b<> <EOF>
We were trying to get the line start position for line 3, but there is
no line 3. Fix by bailing out early if we are the last line in the
file because there is nothing to fix in that case.
Fixes golang/go#37226.
Change-Id: I4ad5746d7b55bdcc2de57c04e972c15a61084faa
Reviewed-on: https://go-review.googlesource.com/c/tools/+/219498
Run-TryBot: Muir Manders <muir@mnd.rs>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.