| commit | ea370293d77d138b8331696866925ab3e73ba4e1 | [log] [tgz] |
|---|---|---|
| author | Rob Findley <rfindley@google.com> | Mon Jun 28 10:04:03 2021 -0400 |
| committer | Robert Findley <rfindley@google.com> | Fri Jul 02 16:14:25 2021 +0000 |
| tree | e3792571662289d73433585d7d2c74dc224a49db | |
| parent | 20dafe5d6055a2382de349face79f568e574d9fd [diff] |
internal/lsp/lsprpc: use middleware for the V2 handshaking The number of concerns satisfied by the lsprpc package is proving to be a barrier to both factoring out the debug and event package, and use of service discovery. The new Binder API admits a nice abstraction that can help make the lsprpc package more modular, or perhaps even unnecessary: a binder middleware that can instrument all aspects of the connection lifecycle. In this CL, this pattern is used to decouple the server handshake from the actual forwarding setup. Later CLs will implement additional functionality using this pattern. The TestEnv helper is refactored to be more scriptable. Change-Id: I6060bc4bba57e4ee7e161a5d6edbc40c6fccbaa8 Reviewed-on: https://go-review.googlesource.com/c/tools/+/331369 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Ian Cottrell <iancottrell@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.