tree 6ad715b4da9c47927a8d97863b4ee43127fd21e7
parent 8087911863a8b7dcb44166290f838e06ef1bbfdc
author Robert Findley <rfindley@google.com> 1673552823 -0500
committer Robert Findley <rfindley@google.com> 1673554071 +0000

gopls/internal/regtest: eliminate DiagnosticsFor

As noted in the associated TODO, DiagnosticsFor is racy. Remove it,
replacing uses with the atomic ReadDiagnostics expectation.

Also replace nearby Awaits with AfterChange, to make them fail eagerly.

Change-Id: Idb5c2420cd0d9b28e701343bc8d2883eea4e144a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/461875
Reviewed-by: Alan Donovan <adonovan@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>