tree d9e5ce03763a60b971f6b1d1fe2644357eb9dd50
parent ff22fab9324c4ef0a092e88fd0fdce98d3833698
author Robert Findley <rfindley@google.com> 1669665486 -0500
committer Robert Findley <rfindley@google.com> 1669742100 +0000

gopls/internal/lsp: remove access to mutable session state from the view

To avoid concurrency bugs and/or operation on inconsistent session
state, remove visibility into the session from views. In a few places,
this refactoring highlighted bugs (such as incorrect usage of
view.SetOptions).

This broke one of the debug templates, for which it was simply easier to
remove the back-link from view to session.

Change-Id: I4dbce0dcebab6f25a9c70524310ae1e0e04e2d97
Reviewed-on: https://go-review.googlesource.com/c/tools/+/453815
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>