x/tools/go/internal/gcimporter: exclude a file from TestImportTypeparamTests
Matching change for the corresponding file in CL 353389.
To make the builds pass for now.
For golang/go#48424.
Change-Id: Id66837957ffec4e4b19faa0337a7587ea8bd6125
Reviewed-on: https://go-review.googlesource.com/c/tools/+/353395
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
diff --git a/go/internal/gcimporter/iexport_go118_test.go b/go/internal/gcimporter/iexport_go118_test.go
index 3c9610e..50ac0f7 100644
--- a/go/internal/gcimporter/iexport_go118_test.go
+++ b/go/internal/gcimporter/iexport_go118_test.go
@@ -80,6 +80,10 @@
t.Skip("unified export data format is currently unsupported")
}
+ skip := map[string]string{
+ "issue48424.go": "go/types support missing", // TODO: need to implement this if #48424 is accepted
+ }
+
for _, entry := range list {
if entry.IsDir() || !strings.HasSuffix(entry.Name(), ".go") {
// For now, only consider standalone go files.
@@ -87,17 +91,23 @@
}
t.Run(entry.Name(), func(t *testing.T) {
+ if reason, ok := skip[entry.Name()]; ok {
+ t.Skip(reason)
+ }
+
filename := filepath.Join(rootDir, entry.Name())
src, err := os.ReadFile(filename)
if err != nil {
t.Fatal(err)
}
+
if !bytes.HasPrefix(src, []byte("// run")) && !bytes.HasPrefix(src, []byte("// compile")) {
// We're bypassing the logic of run.go here, so be conservative about
// the files we consider in an attempt to make this test more robust to
// changes in test/typeparams.
t.Skipf("not detected as a run test")
}
+
testExportSrc(t, src)
})
}
