internal/lsp: switch to 'go get -u ./...' for transitive upgrades
'go get -u all' works for this in Go 1.16, but in earlier versions,
we need 'go get -u ./...'. Also, include the -d and -t flags to avoid
building binaries and to upgrade test dependencies.
Fixes golang/go#45262
Change-Id: I8b04783ffcd53e8066c5a25fef72d91ae975f5a2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/307889
Trust: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
diff --git a/internal/lsp/mod/code_lens.go b/internal/lsp/mod/code_lens.go
index 1598ed5..d7310c7 100644
--- a/internal/lsp/mod/code_lens.go
+++ b/internal/lsp/mod/code_lens.go
@@ -50,7 +50,7 @@
upgradeTransitive, err := command.NewUpgradeDependencyCommand("Upgrade transitive dependencies", command.DependencyArgs{
URI: uri,
AddRequire: false,
- GoCmdArgs: []string{"-u", "all"},
+ GoCmdArgs: []string{"-d", "-u", "-t", "./..."},
})
if err != nil {
return nil, err
@@ -58,7 +58,7 @@
upgradeDirect, err := command.NewUpgradeDependencyCommand("Upgrade direct dependencies", command.DependencyArgs{
URI: uri,
AddRequire: false,
- GoCmdArgs: requires,
+ GoCmdArgs: append([]string{"-d"}, requires...),
})
if err != nil {
return nil, err
