tree 8e44397b7a4b406bc8f4faa5eceb03e8bb24d80a
parent 364bdd0eb2ddfc364bf1b9f067fe0089ba358e28
author Rob Findley <rfindley@google.com> 1690307832 -0400
committer Robert Findley <rfindley@google.com> 1690316729 +0000

gopls/internal/lsp/cache: use correct metadata in resolveImportGraph

Following CL 510095, we no longer await loading in resolveImportGraph.
However, we were still acquiring the snapshot metadata once, before
requesting MetadataForFile.

This means that the metadata used to build package handles had more
information than the metadata used to invalidate volatile package
handles, causing some deps not to be present in the handles map.

While at it, change cache.Package to hold only Metadata, not
packageHandle. Going forward, packageHandles should be scoped more
narrowly to the typecheckBatch logic.

Fixes golang/go#61512

Change-Id: I32fc248b3b1329e071caf0cb304f55a6a29f8c49
Reviewed-on: https://go-review.googlesource.com/c/tools/+/513095
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>