| commit | e5f3ab76ea4b26ebea349e4994ee72d38250c9b0 | [log] [tgz] |
|---|---|---|
| author | Daniel Martí <mvdan@mvdan.cc> | Mon Nov 19 13:34:02 2018 +0000 |
| committer | Daniel Martí <mvdan@mvdan.cc> | Mon Dec 03 21:00:56 2018 +0000 |
| tree | 761e1f508ee8216c7713beab4bf8b4f6a739f3cf | |
| parent | 99b2a93e1f84a3dfa8da651b94e2e176187fc2a9 [diff] |
go/analysis: fix more printf pointer bugs The first issue is that %b and %o can print pointers, but printVerbs didn't reflect that: The %b, %d, %o, %x and %X verbs also work with pointers, formatting the value exactly as if it were an integer. The second issue is that arrays can never be printed as pointers. This was previously reported as part of #27672. The third issue is that only %p can print all slices, maps, and functions as if they were pointers. This differs from verbs like %b or %o, which can't print these types as pointers. Fix all of the issues above, and add extensive test cases covering all the combinations. Verified all of them with an executed program. The amount of test cases is perhaps overkill, but this is not the first time we've gotten the printf pointer logic wrong. Updates #27672. Fixes #28858. Change-Id: I62eb79d505fd1e250a16b90bda3c68b702f35a29 Reviewed-on: https://go-review.googlesource.com/c/149979 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.