| commit | e54115a0622c5325aff9076ff6116307d9e5cbbc | [log] [tgz] |
|---|---|---|
| author | Muir Manders <muir@mnd.rs> | Thu Apr 25 20:26:22 2019 +0000 |
| committer | Rebecca Stambler <rstambler@golang.org> | Thu Apr 25 21:19:06 2019 +0000 |
| tree | 33c62a312ab326f7edd26a189a71702c7c02eb38 | |
| parent | bb8aefc696b9add0862ca2f5f56272cf9540748d [diff] |
internal/lsp: fix stuck diagnostic messages The "analyses" cache in lsp/cache.(*Package).GetActionGraph was not getting cleared on errors. This could result in future calls to GetActionGraph waiting on the "ready" channel indefinitely. This in turn caused the goroutine in cacheAndDiagnose to block indefinitely and never send the diagnostic results back. Now we use a defer statement to always close the channel. If we did not succeed, we also clear out the cache entry and set a "succeeded = false" flag to signal waiters that they need to retry. If in the future errors other than context.Canceled/Timeout are possible, this retry behavior may need to be revisited. Fixes golang/go#30786 Change-Id: Icacc9188f1500b00f2178521ce373a2c1363f932 GitHub-Last-Rev: 7c43afd4286a69b0d35a625716e6934c72c4cef5 GitHub-Pull-Request: golang/tools#91 Reviewed-on: https://go-review.googlesource.com/c/tools/+/173977 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.