| commit | e48fac377d72c8c86f43970b592fd749bdc0667f | [log] [tgz] |
|---|---|---|
| author | Paul Jolly <paul@myitcv.io> | Sun Apr 19 17:07:45 2020 +0100 |
| committer | Paul Jolly <paul@myitcv.org.uk> | Mon May 11 19:21:19 2020 +0000 |
| tree | ec62d961e0b64d5a302281f310b097f47a74b17c | |
| parent | da4261a3d099091d1f49be6352e42b43e54aece8 [diff] |
internal/lsp: change workspace symbols to use session config for matcher WorkspaceSymbols matches symbols across views using the given query, according to the matcher Matcher. The workspace symbol method is defined in the spec as follows: > The workspace symbol request is sent from the client to the server to > list project-wide symbols matching the query string. It is unclear what "project-wide" means here, but given the parameters of workspace/symbol do not include any workspace identifier, then it has to be assumed that "project-wide" means "across all workspaces". Hence why WorkspaceSymbols receives the views []View. However, it then becomes unclear what it would mean to call WorkspaceSymbols with a different configured Matcher per View. Therefore we assume that Session level configuration will define the Matcher to be used for the WorkspaceSymbols method. As part of this change we also tidy up lsp_test.go and source_test.go to remove some repetition. Change-Id: I444f9a78303ac9d2c8d8ac6496603b5758e4aafd Reviewed-on: https://go-review.googlesource.com/c/tools/+/228763 Run-TryBot: Paul Jolly <paul@myitcv.org.uk> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.