| commit | e0f1ed8c47531017f8b5e753cf00d3003c27a8bd | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Wed Dec 18 13:32:01 2019 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Thu Jan 23 00:24:11 2020 +0000 |
| tree | 75c94472c03d2f6e1aa644a3106c8030019dcfcb | |
| parent | bf1340f18c4a84892158455a762da3c45c604c7a [diff] |
go/packages: refactor list driver Many functions in the list driver took the Config and goInfo functions. Consolidate into a state object and move most functions to methods on it. Rework asynchronous go command calls -- rather than always running them and waiting for them to finish, run on demand and attach them all to a Context that is cancelled when the function returns. This does risk letting them run a tiny bit over, but it should be harmless, and it's a lot easier to pass the right Context around than to try and wait for everything. Propagate errors that were previously swallowed. All the tests still pass, and hopefully nobody is hitting the errors cases. If I'm wrong we can start swallowing them again. Tweak and reword various comments that I thought could be improved. Change-Id: I78457dd5493de3e9cb97f17dfe222d7cc9a478e9 Reviewed-on: https://go-review.googlesource.com/c/tools/+/215938 Reviewed-by: Michael Matloob <matloob@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.