commit dfebd2802ad38c7b8e5972cd02d0283b105433f5
author Muir Manders <muir@mnd.rs> Mon Dec 09 08:36:55 2019 -0800
committer Rebecca Stambler <rstambler@golang.org> Wed Dec 11 23:36:49 2019 +0000
tree 23d1abb4d4eed6f3d8d74afe5cf093ff7499d29d
parent ad473c03aa65297ab7b5c17f80d284b6a8d96504

internal/lsp: fix find-references to search from all package variants

We previously searched the reverse dependencies of the "widest"
package that contained out starting identifier, but if our package has
tests then the widest package is the ".test" variant, and it has no
reverse dependencies. Fix by searching through all of the packages
that contain our starting identifier.

For example:

-- foo/foo.go --
package foo
func Foo() {}

-- foo/foo_test.go --
package foo
func TestFoo(t *testing.T) {}

-- bar/bar.go --
import "foo"
func _() {
  foo.Foo()
}

We would start searching from the foo.test variant, but we wouldn't
search package bar at all because bar does not import foo.test, it
imports plain foo. Now we search from both foo and foo.test (you still
need search foo.test to find references within foo_test.go).

Fixes golang/go#35936.

Change-Id: I5fd2f7bb130a421ed6fad92da11179995c99a2cf
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210537
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>