tree d28b57dc6e5572b99dd41d2768963bb3fa273973
parent 53efd30f4782fe19cfaafd2383ee6eb93ec35f93
author xzb <2598514867@qq.com> 1732723435 +0000
committer Gopher Robot <gobot@golang.org> 1732733255 +0000

gopls/internal/undeclaredname: add missing colon when appropriate

This CL improves the undeclared-variable quick fix
 by adding the missing colon when appropriate, that is:
1) When the first occurrence of undefined ident's parent within
function is an AssignStmt, and it sits in the left hand side;
2) Its Tok is set to token.ASSIGN (=);
3) Ident must not be self assignment.

Prior to this CL:
1) the new generated one simply sits above
the cursor position, while this CL insert it before the first
undefined ident with the same name.
2) It results in a syntax error, as stated in https://go-review.googlesource.com/c/tools/+/623156/comment/09944936_9d2835c2/,
so this CL also adds a default value derived from its type.

Fixes golang/go#69980

Change-Id: I4ccad852f89bc60034ade856ad5b1490686fc1e8
GitHub-Last-Rev: 378bdfdccbd8e63ec1a45dd4bfdc6c5249d19a4f
GitHub-Pull-Request: golang/tools#545
Reviewed-on: https://go-review.googlesource.com/c/tools/+/629895
Auto-Submit: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Veronica Silina <veronicasilina@google.com>