Google Git
Sign in
go / tools / df87831b1a0e07de92bf495a0bc9e71af7e62d2a
commitdf87831b1a0e07de92bf495a0bc9e71af7e62d2a[log] [tgz]
authorxzb <2598514867@qq.com>Wed Nov 27 16:03:55 2024 +0000
committerGopher Robot <gobot@golang.org>Wed Nov 27 18:47:35 2024 +0000
treed28b57dc6e5572b99dd41d2768963bb3fa273973
parent53efd30f4782fe19cfaafd2383ee6eb93ec35f93 [diff]
gopls/internal/undeclaredname: add missing colon when appropriate

This CL improves the undeclared-variable quick fix
 by adding the missing colon when appropriate, that is:
1) When the first occurrence of undefined ident's parent within
function is an AssignStmt, and it sits in the left hand side;
2) Its Tok is set to token.ASSIGN (=);
3) Ident must not be self assignment.

Prior to this CL:
1) the new generated one simply sits above
the cursor position, while this CL insert it before the first
undefined ident with the same name.
2) It results in a syntax error, as stated in https://go-review.googlesource.com/c/tools/+/623156/comment/09944936_9d2835c2/,
so this CL also adds a default value derived from its type.

Fixes golang/go#69980

Change-Id: I4ccad852f89bc60034ade856ad5b1490686fc1e8
GitHub-Last-Rev: 378bdfdccbd8e63ec1a45dd4bfdc6c5249d19a4f
GitHub-Pull-Request: golang/tools#545
Reviewed-on: https://go-review.googlesource.com/c/tools/+/629895
Auto-Submit: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Veronica Silina <veronicasilina@google.com>
6 files changed
tree: d28b57dc6e5572b99dd41d2768963bb3fa273973
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. godoc/
  9. gopls/
  10. imports/
  11. internal/
  12. playground/
  13. present/
  14. refactor/
  15. txtar/
  16. .gitattributes
  17. .gitignore
  18. .prettierrc
  19. codereview.cfg
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://go.dev/doc/contribute.

The git repository is https://go.googlesource.com/tools.

The main issue tracker for the tools repository is located at https://go.dev/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.