commit df07577eb15b63c13c0ff5c699cc34626b6dcf3f
author Muir Manders <muir@mnd.rs> Fri May 28 17:39:50 2021 -0700
committer Rebecca Stambler <rstambler@golang.org> Tue Jun 01 17:02:03 2021 +0000
tree 47e3a8619faff68ebf841af6e7dbd53d8427e996
parent 6123e5fbf24b143f06d5d267c82115f154ac5a0f

lsp/completion: fix variadic param candidate ordering edge case

In cases like:

    var foo func(...interface{})
    var one int
    var two func() (int, int)

    foo(<>)

At <> we were preferring "two()" over "one" because we were really
excited that the multi return value function was usable. "one" was not
preferred because the expected value is interface{} (we default to
saying candidates _don't_ match interface{} to give non-type based
aspects of candidate inference a chance to shine).

Fix by applying the corresponding interface{} logic to the assignees
checking: ignore the case of completing into func(...interface{})
since all multi return value functions would match.

Fixes golang/go#46378.

Change-Id: I355daa75e067e8b14508ca50b8d3b6b727df5fec
Reviewed-on: https://go-review.googlesource.com/c/tools/+/323509
Run-TryBot: Muir Manders <muir@mnd.rs>
gopls-CI: kokoro <noreply+kokoro@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Trust: Peter Weinberger <pjw@google.com>