tree edc0601284fc516d29db047d1adee85656a8dd02
parent 3393d29bb9feddd4fb8d6d2f81faf9f50b70616d
author Rebecca Stambler <rstambler@golang.org> 1575591476 -0500
committer Rebecca Stambler <rstambler@golang.org> 1575658384 +0000

internal/lsp: fix concurrent map write in file invalidation

The invalidateContent function does not acquire a snapshot's mutex to
avoid blocking other work (even though it probably should since it's
only called after a context is canceled). A case was added to iterate
through files when a file is created, and it did not respect the fact
that the snapshot's mutex was not locked, resulting in a concurrent map
read and write. This change makes sure that the access of the snapshot's
files map is guarded by a mutex.

As a follow-up, we should just acquire snapshot.mu in invalidateContent.

Updates golang/go#36006

Change-Id: Idd904ae582055ce786062df50875ac7f0896fd1c
Reviewed-on: https://go-review.googlesource.com/c/tools/+/210199
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>