| commit | db5406b80163737509b69ad3896f26df3f3ca0c7 | [log] [tgz] |
|---|---|---|
| author | Robert Findley <rfindley@google.com> | Sun Jul 23 15:18:04 2023 -0400 |
| committer | Robert Findley <rfindley@google.com> | Tue Jul 25 15:59:24 2023 +0000 |
| tree | 9547d878c6d38841bda69d2671bd5b3380aea1da | |
| parent | 4810edad4759e613353e31e7f47aa1cb4cbb165c [diff] |
gopls/internal/lsp: don't recompute diagnostics during code actions As noted in an outstanding TODO, there's no reason to re-compute diagnostics during code actions. This may have been cheap in the previous gopls architecture, but still complicated the code. With the new architecture it has significant cost, especially when running analysis with a different set of analyzers. Fix this by instead unbundling serialized code actions, or failing that by matching code action context with previously published diagnostics stored on the server. After doing so, what remained was the additional "diagnostics" produced by convenience analyzers. These are (rather pragmatically) refactored to be computed from typed syntax alone, outside of the analysis framework. Incidentally, this fixes the long-standing golang/go#51478. The analyzers are left as thin shells, so that existing analyzer configuration will continue to work for the short term. Longer term, we should design a new mechanism for parameterizing refactorings and deprecate the old analyzer settings. Make some additional cleanup along the way, and some other relatively superficial changes to get tests to pass. Fixes golang/go#51478 Fixes golang/go#61508 Change-Id: I0218d4fc15a6fdb5f2fd5c0560b9d9afa079b84d Reviewed-on: https://go-review.googlesource.com/c/tools/+/511995 gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> Run-TryBot: Robert Findley <rfindley@google.com>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.