| commit | db513b0915042d9b1ac8cff2c21e191f46578c44 | [log] [tgz] |
|---|---|---|
| author | Tim King <taking@google.com> | Mon Jun 10 14:00:23 2024 -0700 |
| committer | Tim King <taking@google.com> | Fri Jun 21 16:59:57 2024 +0000 |
| tree | 083a15c0a31a1236aaa612177b88d7c7789ef59b | |
| parent | 8a45e6cdbd0a41a18463e79cd29055c258493c21 [diff] |
go/ssa: wait for shared functions to finish building
Package.Build and Program.MethodValue can create and build
Functions that may be depended on by other calls to
Package.Build and Program.MethodValue. Both of these
APIs now wait for any Functions that are shared and depended
on to finish building before returning.
This fixes some data races observed when accessing the Blocks
field of shared functions.
Functions that are members of Packages (fn.Pkg != nil)
are still always built by fn.Pkg.Build().
These dependencies can be create cycles between public API
calls that both depend on Functions the other is building.
For example, both the "net/http" and "internal/trace/testtrace"
packages both depend on slices.Contains[[]string,string] and
slices.Index[[]string, string]. Under some schedules, building
both packages may need to wait for the other package to finish
building before finishing.
This introduces a new internal type task. tasks
allows for waiting on the transitive closure of builders iterating
to be marked as done before proceedind.
Also:
- Add a test that reliably reproduces the data race.
- Refactors creator.add calls to happen after the function is created.
- Merges creator into builder.
- Updates the builder to mark when it is done building and wait
for dependencies.
- Define type unit = struct{} and clean up.
Fixes golang/go#67079
Change-Id: I34d2b8730b19609f5fbf6b55b3db33f59818a17b
Reviewed-on: https://go-review.googlesource.com/c/tools/+/591775
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.
It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.
Selected commands:
cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.cmd/callgraph prints the call graph of a Go program.cmd/digraph is a utility for manipulating directed graphs in textual notation.cmd/stringer generates declarations (including a String method) for “enum” types.cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.These commands may be fetched with a command such as
go install golang.org/x/tools/cmd/goimports@latest
Selected packages:
go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.
go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.
go/analysis provides a framework for modular static analysis of Go programs.
go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.
go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.
go/cfg provides a simple control-flow graph (CFG) for a Go function.
go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.
go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.
go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.
Numerous other packages provide more esoteric functionality.
This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.