commit | db3e1ec26de3052b985a7b878e14caf67137533d | [log] [tgz] |
---|---|---|
author | Heschi Kreinick <heschi@google.com> | Thu Nov 19 23:03:37 2020 -0500 |
committer | Heschi Kreinick <heschi@google.com> | Mon Nov 23 19:09:50 2020 +0000 |
tree | 4cd0ba29376ff9072ac6d6d850fb4d1cdd3d98c3 | |
parent | a9763abba00f0731b51ee7bc61656fc4d5ec239c [diff] |
internal/lsp: use pointers to source.Error, and not to ErrorList We should be consistent about whether we pass around Error or *Error. *Error was somewhat more common, and its Error method has a pointer receiver, so I picked *Error. ErrorList, on the other hand, is usually dereferenced when used, and slice headers are small enough to pass around casually. So switch that over to a non-pointer and change its Error method to a value receiver. Change-Id: I19e70201ed1d6ef36d217db21c9101bb810bcf0c Reviewed-on: https://go-review.googlesource.com/c/tools/+/272092 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.