commit | 9c452d85743e08cafcd8d47f73f923cb4b239f8b | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Tue Mar 02 14:26:06 2021 -0500 |
committer | Robert Findley <rfindley@google.com> | Wed Mar 03 15:21:54 2021 +0000 |
tree | a19fffa308b03d645d9db37bb2a7924b25d63571 | |
parent | 2ac05c832e1ab1618e10cb020a529f1053018608 [diff] |
internal/lsp/cache: don't rely on related diagnostics if unsupported In CL 295413 we fixed the handling of related type checker diagnostics to correctly identify the primary and secondary errors at a position. However, on clients that don't support diagnostic related information, this can lead to confusing primary diagnostics. Add handling for clients that don't support related information, to embed the secondary error in the primary error. Fixes golang/go#44735 Change-Id: I3d2470d2a4044661e6ed31ac9ffd2f9ff27f7d4b Reviewed-on: https://go-review.googlesource.com/c/tools/+/297875 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.