tree e936524bc71c0d8c7845540398f771f49dab8f53
parent cf83efe03cf89b09f33be7e464f1c95f6c3393aa
author Heschi Kreinick <heschi@google.com> 1597689386 -0400
committer Heschi Kreinick <heschi@google.com> 1597864935 +0000

internal/lsp/cache: don't always type check in default mode

CL 248380 forced all type checking to be in the default workspace mode.
In that CL, I said I couldn't think of any features that would break. It
appears I didn't think very hard. Navigation features inside of
dependencies are something I use all the time and they broke.

Reintroduce the ability to get packages in a particular mode, and make
it convenient to get them in all relevant modes. Update some critical
features to do so, and add regression tests.

Fixes golang/go#40809.

Change-Id: I96279f4ff994203694629ea872795246c410b206
Reviewed-on: https://go-review.googlesource.com/c/tools/+/249120
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>