tree d6dbd1e425440c54400950205394ff18a4148d13
parent d299b94661a0861681b42a923644618f8840a097
author Robert Findley <rfindley@google.com> 1651764498 -0400
committer Robert Findley <rfindley@google.com> 1651854254 +0000

internal/lsp/source/completion: use typeutil.Map for short-circuiting

While working on golang/go#52715, I discovered an infinite recursion in
gopls' completion logic: eachField assumes a finiteness of type pointers.

It is almost certainly a go/types bug that type-checked types expand
infinitely, but nevertheless we should use the more accurate
typeutil.Map for short-circuiting our search.

Change-Id: Ib1c7125e624f42882869acd4e0476e317d4da056
Reviewed-on: https://go-review.googlesource.com/c/tools/+/404335
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>