commit d73e1c7e250b19f9948138e2df37cea712e8f06f
author Muir Manders <muir@mnd.rs> Tue Jun 11 22:07:34 2019 +0000
committer Rebecca Stambler <rstambler@golang.org> Tue Jun 11 22:22:05 2019 +0000
tree 749258819d2bffe429ace2375aff306f32b943ea
parent 3c1b0c2805ae93e484dea8ba21342a28440a596d

internal/lsp: fix errors when adding new file to existing package

Previously when you added a new file to an existing package, the new
file would get stuck with the "no package for file" error until you
saved the file and then made changed a different file in the
package. There were two changes required to fix the errors:

First, we need to invalidate the package cache when a new file is
added to a package so that the package will actually re-parse and
re-type check. We now notice if file names changed when updating a
package's metadata and invalidate the package cache accordingly.

Second, when dealing with overlay (unsaved) files, we need to map
the *goFile to the package even if we fail to parse the
file (e.g. the new file fails to parse when it is empty). If we don't
map it to the package, the package won't get refreshed as the file is
changed.

Fixes golang/go#32341

Change-Id: I1a728fbedc79da7d5fe69554a5893efcd1e1d902
GitHub-Last-Rev: e7c3d4c1f8f73b12c87ee76d868cc04893e55808
GitHub-Pull-Request: golang/tools#111
Reviewed-on: https://go-review.googlesource.com/c/tools/+/181417
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>