Google Git
Sign in
go / tools / d59a28f927a466dba18287a776f6ea21723de738
commitd59a28f927a466dba18287a776f6ea21723de738[log] [tgz]
authorAlan Donovan <adonovan@google.com>Fri Apr 21 16:40:05 2023 -0400
committerRobert Findley <rfindley@google.com>Mon Apr 24 19:42:53 2023 +0000
tree6f8f4f97d16c1f4bb2408e64212317b46f23804d
parente8f417a962ed6ed4ce93226507cc6e6d007c386b [diff]
gopls/internal/lsp/source: references: restrict search to workspace packages

This change restricts the scope of the search to workspace
packages so that we don't report irrelevant references,
and more importantly, spend a lot of time type-checking them.

Conceptually, we simply call call snapshot.WorkspaceMetadata
and intersect the resulits of the ReverseDependency operations
with it.

However, the diff is somewhat trickier because it merges the
old call to snapshot.WorkspaceMetadata within expandMethodSearch
into the new one, and downgrades 'expansions' into a set of IDs
so that expandMethodSearch needn't trade in Metadatas.
It also factors the removal of intermediate test variants
that was previously done in two places, by applying it
to the workspace set.

Casual testing (searching for refs to os.File.Close in
kubernetes, using the CLI tool which performs an IWL)
suggests that it is >2x faster:
v0.11.0 = 35s; master = 20s; this CL = 14s.

Also, a test.

Fixes golang/go#59674

Change-Id: I58c072af7f878f4d64ceffd5b62a68bc3e5daae4
Reviewed-on: https://go-review.googlesource.com/c/tools/+/487017
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Alan Donovan <adonovan@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
6 files changed
tree: 6f8f4f97d16c1f4bb2408e64212317b46f23804d
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. godoc/
  9. gopls/
  10. imports/
  11. internal/
  12. playground/
  13. present/
  14. refactor/
  15. txtar/
  16. .gitattributes
  17. .gitignore
  18. .prettierrc
  19. codereview.cfg
  20. CONTRIBUTING.md
  21. go.mod
  22. go.sum
  23. LICENSE
  24. PATENTS
  25. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/expect reads Go source files used as test inputs and interprets special comments within them as queries or assertions for testing.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://golang.org/doc/contribute.html.

The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.