| commit | d57727d3ee93ed2f48cfa454e1165224d18dcbb3 | [log] [tgz] |
|---|---|---|
| author | Rebecca Stambler <rstambler@golang.org> | Tue Feb 16 14:36:11 2021 -0500 |
| committer | Rebecca Stambler <rstambler@golang.org> | Tue Feb 16 23:14:39 2021 +0000 |
| tree | 68a2b67173b178643ea7ddc45c3a3265d08192e8 | |
| parent | 98d911f9515a584a4dfba4c975248d89e44684eb [diff] |
internal/lsp: fix nil pointer in hover when (types.Object).Pkg() is nil We haven't been able to reproduce this scenario, but it may be possible when the user is in a broken state. Avoid panicking by gating every use of obj.Pkg() with nil checks. Fixes golang/go#44300 Change-Id: Ia0c56a7fd5d6b89795dded1efdf05838f3de8209 Reviewed-on: https://go-review.googlesource.com/c/tools/+/292671 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> (cherry picked from commit ffc207509abf826f12724821620192fb29524064) Reviewed-on: https://go-review.googlesource.com/c/tools/+/292730 Reviewed-by: Robert Findley <rfindley@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.