commit | d56e4e40bc9dd04985b18718e43413d9f4399fb5 | [log] [tgz] |
---|---|---|
author | Heschi Kreinick <heschi@google.com> | Thu Sep 17 15:49:24 2020 -0400 |
committer | Heschi Kreinick <heschi@google.com> | Thu Sep 17 22:16:17 2020 +0000 |
tree | 70c03eca1cd689208ef0d6351f83b6fef1f93336 | |
parent | 3791637d67921d7b46640615a2173e9e01e4ec54 [diff] |
internal/lsp/cache: set GO111MODULE=auto in 1.16 1.16 wants to set GO111MODULE=on. There are, AFAIK, two differences between "auto" and "on". First, if you're in a directory outside of GOPATH and with no go.mod, "on" will run in module mode with GOMOD=os.DevNull. I don't think we care very much about that. Second, if you're in GOPATH with no go.mod, "on" will run in module mode, breaking GOPATH mode. Breaking GOPATH mode may be desirable for the go command generally, but for gopls I think it will lead to an unnecessarily bad user experience. Users will find out when they do their first build or test; there's IMO no need to also break their editor. Flip the default back to "auto". Change-Id: I280e001a9f7e80d65e68c0cb94353d70a7f5425e Reviewed-on: https://go-review.googlesource.com/c/tools/+/255781 Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Heschi Kreinick <heschi@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.