commit | d4cc65f0b2ff86a8ea502e02a79168a16b992872 | [log] [tgz] |
---|---|---|
author | Matthew Dempsky <mdempsky@google.com> | Fri Aug 20 12:29:25 2021 -0700 |
committer | Matthew Dempsky <mdempsky@google.com> | Fri Aug 20 21:27:50 2021 +0000 |
tree | 00a10b4a7046def0fa69ee67d5db4f80923c62b8 | |
parent | bf6c7f26e9f0fea5b256f9ef6968435dddc5be25 [diff] |
gopls/internal/regtest/codelens: avoid compiler bug Because of how the compiler internally represents variable references, it sometimes gets position information incorrectly for them. The codelens test hits this issue because for var x string fmt.Println(x) the diagnostic about "x" escaping to heap (which actually refers to the implicit conversion to "interface{}" type) should be rightly reported at the "x" identifier within the call arguments list. However, due to the aforementioned compiler bug, historically we reported the diagnostic at the "(" token instead. In -G=3 mode, the compiler (correctly) report the diagnostic at "x" instead; but with GOEXPERIMENT=unified, the compiler intentionally matches the original -G=0 behavior and continues reporting at "(" instead. This CL avoids the issue entirely by changing the line to "fmt.Println(42)", which avoids the issue because the compiler always correctly prints the diagnostic then at "42". Change-Id: I22d4c756ae801489f3f16c440e4339bc9b115fb0 Reviewed-on: https://go-review.googlesource.com/c/tools/+/343875 Trust: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Matthew Dempsky <mdempsky@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.