| commit | d25f9066828099517056ecb554d8d0b84f026ddd | [log] [tgz] |
|---|---|---|
| author | Karthik Nayak <karthik.188@gmail.com> | Thu Jun 17 19:13:30 2021 +0000 |
| committer | Rebecca Stambler <rstambler@golang.org> | Fri Jun 18 18:34:00 2021 +0000 |
| tree | 30af5eac21ebc4d32678721dd69f82c6914af74a | |
| parent | 463a76b3dc7546fb34cbac5dbc48b4ed68eb96e8 [diff] |
internal/lsp: do not block on channel when there is an error In `internal/lsp/cmd.(*connection).diagnoseFiles`, when we request for `gopls/diagnoseFiles`, we are blocked on the channel even if there is an error. In such a scenario, we've reach a deadlock since. Avoid this by checking for error, existing if it exists and also closing the channel while we're at it. Fixes golang/go#46251 Signed-off-by: Karthik Nayak <karthik.188@gmail.com> Change-Id: I4266ab3ac272a9ae3eac2084b70b6568b72c1984 GitHub-Last-Rev: 94bf2926a0f35d51d62643618a8072ef5a8b5225 GitHub-Pull-Request: golang/tools#324 Reviewed-on: https://go-review.googlesource.com/c/tools/+/329109 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Trust: Rebecca Stambler <rstambler@golang.org> Trust: Heschi Kreinick <heschi@google.com> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.