commit | d255de4fdb38f8f5dbaf12b83013784a30f97a55 | [log] [tgz] |
---|---|---|
author | Muir Manders <muir@mnd.rs> | Tue Jul 09 17:09:04 2019 +0000 |
committer | Rebecca Stambler <rstambler@golang.org> | Tue Jul 09 18:24:20 2019 +0000 |
tree | 7f7802c504b1398ebb19d4c9a3532b852267ab12 | |
parent | 07655f7ec712a8fd796ed69ce5895539910e1248 [diff] |
internal/lsp: don't refresh metadata when context canceled We err on the side of refreshing package metadata if something goes wrong getting a file's AST, but we don't want to refresh in the case of context cancellation. Now we check for that error explicitly. In particular, I noticed that completions would stop working when typing quickly. Refreshing the metadata triggers "go list" calls which can take a long time in certain cases. Change-Id: I1b0c580e5541b1536a69ccaef241d7e8c5720d60 GitHub-Last-Rev: 6a82bfb586f93ef5e8e5996b11e06ffc7808f529 GitHub-Pull-Request: golang/tools#130 Reviewed-on: https://go-review.googlesource.com/c/tools/+/184977 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.