| commit | cef9fc3bc8f05cfb366ee24e1bea7584745a42d8 | [log] [tgz] |
|---|---|---|
| author | Josh Baum <joshbaum@google.com> | Thu Jun 04 15:57:03 2020 -0400 |
| committer | Josh Baum <joshbaum@google.com> | Fri Jun 05 18:10:38 2020 +0000 |
| tree | d24b1571f171b1152f9056d9ed12c6f255fde340 | |
| parent | 16794747803a2b5d654fd304f8ecc5ca7fff65cb [diff] |
internal/lsp/analysis/fillreturns: broaden type equality The existing implementation contains strict equality rules for comparing the return type in the function declaration against the return types in the function body. This causes the code in the return statement to be incorrectly overriden with its corresponding zero value type by the fillreturns analyzer. Fixes golang/go#38707 Change-Id: I07522aaf85f2a5f811a86cbc0951ae61035ff55e Reviewed-on: https://go-review.googlesource.com/c/tools/+/236617 Reviewed-by: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses prettier to format JS and CSS files.
The version of prettier used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.