Google Git
Sign in
go / tools / ce95316806720072658e58867f7426cee33c98b9
commitce95316806720072658e58867f7426cee33c98b9[log] [tgz]
authorAlan Donovan <adonovan@google.com>Thu Oct 30 16:01:50 2025 -0400
committerAlan Donovan <adonovan@google.com>Tue Nov 04 17:46:06 2025 -0800
treec5714360f6964ef166525bc904109dc95c34b276
parentb74c09864920a69a4d2f6ef0ecb4f9cff226893a [diff]
go/analysis/internal/analysisflags: -fix: remove unused imports

This change defines analysisflags.FormatSourceRemoveImports, a
replacement for format.Source that removes imports that are no
longer needed in a modified file.

It requires the types.Package for the unmodified file so that it
can tell what name is declared by an existing non-renaming import.
Any name declared by an import that is not free in the rest of
the file is considered redundant, and is removed.

Individual analyzers typically remove an import when they can
tell that this is necessary, but when several fixes are composed,
and each removes the second-last reference to an import, the
problem must be solved holistically; thus the right place is
in the anlayzer driver.

The new function is used in unitchecker, single/multichecker,
and analysistest.

It is tested indirectly via tests of individual analyzers such
as inline and modernize.

Fixes golang/go#72035

Change-Id: I490e160c11efd44ac63f5c33dac7c1b94c425258
Reviewed-on: https://go-review.googlesource.com/c/tools/+/717802
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
9 files changed
tree: c5714360f6964ef166525bc904109dc95c34b276
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. gopls/
  9. imports/
  10. internal/
  11. playground/
  12. present/
  13. refactor/
  14. txtar/
  15. .gitattributes
  16. .gitignore
  17. .prettierrc
  18. codereview.cfg
  19. CONTRIBUTING.md
  20. go.mod
  21. go.sum
  22. LICENSE
  23. PATENTS
  24. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://go.dev/doc/contribute.

The git repository is https://go.googlesource.com/tools.

The main issue tracker for the tools repository is located at https://go.dev/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.