Google Git
Sign in
go / tools / c9ea5584798279277cda8df97eb8224c40527c31
commitc9ea5584798279277cda8df97eb8224c40527c31[log] [tgz]
authorAlan Donovan <adonovan@google.com>Thu Oct 23 20:55:40 2025 -0400
committerGopher Robot <gobot@golang.org>Fri Oct 24 15:15:08 2025 -0700
tree36da31986ece66b3fcfc25343c872d034c59203a
parentc0daa7fbe5b36ad50cae9e03c802ce0d3752774f [diff]
gopls/internal/golang: Hover: use Cursor throughout

This CL replaces the use of []Node slices from
PathEnclosingInterval by the use of Cursor.FindByPos,
which simplifies a number of algorithms.

In particular, the various ways of finding an
Object from a source position have been consolidated
and clarified in objectsAt.

This sets us up to fix the attached issue in the next CL.

Details:
- Use cursorutil.FirstEnclosing in more places.
- Ditto internalastutil.NodeContains.
- Avoid numerous calls to PathEnclosingInterval.
- pathEnclosingObjNode has gone away.
  All callers use Cursor.Find* or objectsAt.
  Its logic for StarExpr has moved into objectsAt.
- hoverDefinitionObjectAtPos merged into objectsAt.
  Its logic for embedded fields has been pulled
  out into Definition and Hover (two copies),
  which are the only callers that want it.
  A follow-up CL will delete it from Hover since
  it is the cause of golang/go#75975.
- typeSwitchImplicits rewritten more simply (as
  typeSwitchVars) using Cursor.

For golang/go#75975

Change-Id: Ifd62dd3499320f7e7de590348d8769adcdae395e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/714640
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Auto-Submit: Alan Donovan <adonovan@google.com>
14 files changed
tree: 36da31986ece66b3fcfc25343c872d034c59203a
  1. benchmark/
  2. blog/
  3. cmd/
  4. container/
  5. copyright/
  6. cover/
  7. go/
  8. gopls/
  9. imports/
  10. internal/
  11. playground/
  12. present/
  13. refactor/
  14. txtar/
  15. .gitattributes
  16. .gitignore
  17. .prettierrc
  18. codereview.cfg
  19. CONTRIBUTING.md
  20. go.mod
  21. go.sum
  22. LICENSE
  23. PATENTS
  24. README.md
README.md

Go Tools

PkgGoDev

This repository provides the golang.org/x/tools module, comprising various tools and packages mostly for static analysis of Go programs, some of which are listed below. Use the “Go reference” link above for more information about any package.

It also contains the golang.org/x/tools/gopls module, whose root package is a language-server protocol (LSP) server for Go. An LSP server analyses the source code of a project and responds to requests from a wide range of editors such as VSCode and Vim, allowing them to support IDE-like functionality.

Selected commands:

  • cmd/goimports formats a Go program like go fmt and additionally inserts import statements for any packages required by the file after it is edited.
  • cmd/callgraph prints the call graph of a Go program.
  • cmd/digraph is a utility for manipulating directed graphs in textual notation.
  • cmd/stringer generates declarations (including a String method) for “enum” types.
  • cmd/toolstash is a utility to simplify working with multiple versions of the Go toolchain.

These commands may be fetched with a command such as

go install golang.org/x/tools/cmd/goimports@latest

Selected packages:

  • go/ssa provides a static single-assignment form (SSA) intermediate representation (IR) for Go programs, similar to a typical compiler, for use by analysis tools.

  • go/packages provides a simple interface for loading, parsing, and type checking a complete Go program from source code.

  • go/analysis provides a framework for modular static analysis of Go programs.

  • go/callgraph provides call graphs of Go programs using a variety of algorithms with different trade-offs.

  • go/ast/inspector provides an optimized means of traversing a Go parse tree for use in analysis tools.

  • go/cfg provides a simple control-flow graph (CFG) for a Go function.

  • go/gcexportdata and go/gccgoexportdata read and write the binary files containing type information used by the standard and gccgo compilers.

  • go/types/objectpath provides a stable naming scheme for named entities (“objects”) in the go/types API.

Numerous other packages provide more esoteric functionality.

Contributing

This repository uses Gerrit for code changes. To learn how to submit changes, see https://go.dev/doc/contribute.

The git repository is https://go.googlesource.com/tools.

The main issue tracker for the tools repository is located at https://go.dev/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.

JavaScript and CSS Formatting

This repository uses prettier to format JS and CSS files.

The version of prettier used is 1.18.2.

It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.