commit | c979f9254a9be60d4e53e9d55534fc5211b079a1 | [log] [tgz] |
---|---|---|
author | Rob Findley <rfindley@google.com> | Tue Jun 29 18:42:34 2021 -0400 |
committer | Robert Findley <rfindley@google.com> | Thu Jul 08 19:53:41 2021 +0000 |
tree | 2b47beabc4e5a46056a67488fb4a4391985969c6 | |
parent | 55cd4804dfa0984a27cd61589b7f56f937e05545 [diff] |
internal/lsp/cache: invalidate packages in setMetadata When setting metadata, we must invalidate any packages that have been computed with old metadata. Also make setMetadata atomic, by locking around it in Load. This is just writing memory after a Load, so should be fast and infrequent. It is critical that our various maps related to metadata are coherent, so it makes sense to err on the side of coarser locking, IMO. Fix a race in TestUpgradeCodeLens. Change-Id: Iee8003b7e52b9f21681bdba08a009824f4ac6268 Reviewed-on: https://go-review.googlesource.com/c/tools/+/331809 Trust: Robert Findley <rfindley@google.com> Run-TryBot: Robert Findley <rfindley@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc
and vet
for example, are included in binary Go distributions.
Others, including the Go guru
and the test coverage tool, can be fetched with go get
.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/...
. You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools
.
This repository uses prettier to format JS and CSS files.
The version of prettier
used is 1.18.2.
It is encouraged that all JS and CSS code be run through this before submitting a change. However, it is not a strict requirement enforced by CI.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.