| commit | c90f89fc780e0dd7793dd56e6bfad1b0dac7ad4d | [log] [tgz] |
|---|---|---|
| author | Rebecca Stambler <rstambler@golang.org> | Thu Dec 05 19:17:56 2019 -0500 |
| committer | Rebecca Stambler <rstambler@golang.org> | Fri Dec 06 18:54:32 2019 +0000 |
| tree | 791586a648ae92d5684ead68858cc8c0ee33fe9d | |
| parent | 5a11726a162d7c305c38568365be93b7ba1f5e5f [diff] |
internal/lsp: fix concurrent map write in file invalidation The invalidateContent function does not acquire a snapshot's mutex to avoid blocking other work (even though it probably should since it's only called after a context is canceled). A case was added to iterate through files when a file is created, and it did not respect the fact that the snapshot's mutex was not locked, resulting in a concurrent map read and write. This change makes sure that the access of the snapshot's files map is guarded by a mutex. As a follow-up, we should just acquire snapshot.mu in invalidateContent. Updates golang/go#36006 Change-Id: Idd904ae582055ce786062df50875ac7f0896fd1c Reviewed-on: https://go-review.googlesource.com/c/tools/+/210199 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> (cherry picked from commit db903f390e86fb3c8432384267eb272105f29479) Reviewed-on: https://go-review.googlesource.com/c/tools/+/210203
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.