| commit | c81e7ae886d18e2eeb01e681ed56f6b90cf2d86c | [log] [tgz] |
|---|---|---|
| author | Heschi Kreinick <heschi@google.com> | Tue Nov 12 16:58:00 2019 -0500 |
| committer | Heschi Kreinick <heschi@google.com> | Tue Nov 12 22:26:51 2019 +0000 |
| tree | b14736345fcef0e3cf8db3e6bea55ed383ed7526 | |
| parent | aa38f8e97acca3a446000a524f892ba64f088b80 [diff] |
internal/lsp/source: unify import adding code We used to need our own copy of astutil.AddNamedImport to use during completion for a variety of reasons, but I think the major one was needing to not format the whole file. The same problem applied to using the imports package. Happily, that was resolved in CL 205678. Now we can use the same implementation on both paths. In addition to removing a bunch of code, that means that unimported completions now add their imports in the right place, respecting goimports grouping and the local configuration setting. Fixes golang/go#35519. Change-Id: I693c2e8b5ced9bac62b1febf1e2db23c770e5a7a Reviewed-on: https://go-review.googlesource.com/c/tools/+/206881 Run-TryBot: Heschi Kreinick <heschi@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This subrepository holds the source for various packages and tools that support the Go programming language.
Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go guru and the test coverage tool, can be fetched with go get.
Packages include a type-checker for Go and an implementation of the Static Single Assignment form (SSA) representation for Go programs.
The easiest way to install is to run go get -u golang.org/x/tools/.... You can also manually git clone the repository to $GOPATH/src/golang.org/x/tools.
This repository uses Gerrit for code changes. To learn how to submit changes to this repository, see https://golang.org/doc/contribute.html.
The main issue tracker for the tools repository is located at https://github.com/golang/go/issues. Prefix your issue with “x/tools/(your subdir):” in the subject line, so it is easy to find.